don't click here

Disassembly Labels

Discussion in 'Engineering & Reverse Engineering' started by Quickman, Dec 24, 2006.

Thread Status:
Not open for further replies.
  1. Quickman

    Quickman

    be attitude for gains Tech Member
    5,604
    19
    18
    :x
    omg porjcet
    It's noteworthy that every disassembly we have so far has used a completely different set of labels for what is essentially the same thing. What I'd like to call for is consistency; using the same style of label for the same things in our disassemblies. This is akin to specifying a particular coding style for a project.

    What say you, S2Btards?
     
  2. Hivebrain

    Hivebrain

    Administrator
    3,087
    216
    43
    53.4N, 1.5W
    Github
    I'm using a mostly-new set of labels for the next S1 disassembly, which I think accurately (and precisely) describes what the code does. I'm also trying to avoid labels that contain the same text as another label (for example, "Level:" and "DemoLevel:"). As for consistency, I'm just going to do my own thing and hopefully other people will just use the same labels as me.
     
  3. drx

    drx

    mfw Researcher
    2,254
    351
    63
    :rolleyes:
    Standardization sucks ass.
     
  4. Quickman

    Quickman

    be attitude for gains Tech Member
    5,604
    19
    18
    :x
    omg porjcet
    I disagree.
     
  5. drx

    drx

    mfw Researcher
    2,254
    351
    63
    :rolleyes:
    Enjoy your lunix.
     
  6. Cinossu

    Cinossu

    Administrator
    2,832
    46
    28
    London, UK
    Sonic the Hedgehog Extended Edition
    Enjoy your reference topics of what labels link to what per disassembly.
     
  7. Aurochs

    Aurochs

    Единый, могучий Советский Союз! Tech Member
    2,343
    0
    0
    Whatever catches my fancy
    If Hivebrain were to put up style guidelines, I would be glad to follow them (hint hint).
     
  8. Shadow Hog

    Shadow Hog

    "I'm a superdog!" Member
    I see what you did there.

    Anyway, I've never dabbled with disassemblies under the virtue that I don't know assembly very well (despite me being very well aware of tutorials to amend such a problem, and having experience with other programming languages like C++ and Java), although I do intend to get my act together and do so at some point... but seriously, a lack of standardization of labels? Well, it kinda depends; if these disassemblies are being based off existing disassemblies, I see no particular excuse for it, but I can see some valid reasons why two people making disassemblies of the same game from scratch would have different names for the same variable. (Of course, I've got absolutely no clue as to what goes into making these disassemblies, so I'm kinda talking out my ass here... damnit, I really need to learn assembly some time.)

    That said, I agree some standardization would be in order. I'd start with what little we have of the raw code from drx's Sonic 2 prototype, and apply the names Sonic Team themselves used wherever it's obvious to do so. Nothing like the name the company who actually made the thing gave it, right?
     
  9. Aurochs

    Aurochs

    Единый, могучий Советский Союз! Tech Member
    2,343
    0
    0
    Whatever catches my fancy
    Half the time their names don't even make sense. It took me three days to figure out that "scralim" means "screen A limit".
     
  10. Quickman

    Quickman

    be attitude for gains Tech Member
    5,604
    19
    18
    :x
    omg porjcet
    I think Sonic Team had character limits on their labels, which we don't have to worry about. Going by their labels would be silly.
     
  11. StephenUK

    StephenUK

    Liquor in the front, poker in the rear Tech Member
    1,678
    0
    16
    Manchester, UK
    Quackshot Disassembly
    I'm already over halfway through doing exactly that. I've been working on commenting and relabelling the S2 disassembly for a while now, but I've taken a break from working on it. Shouldn't be too long before it's finished though.
     
  12. Aurochs

    Aurochs

    Единый, могучий Советский Союз! Tech Member
    2,343
    0
    0
    Whatever catches my fancy
    !!!!!!!!!!!!!!!!!!!!!

    YOU HAVE OFFENDED ME SIR
     
  13. stormislandgal

    stormislandgal

    It's not a phase! Tech Member
    4,534
    10
    18
    Married life <3
    Now what exactly is "H:" and "thunk:"? Also, I thought I saw a label in S2 that was "*:" =P
     
  14. drx

    drx

    mfw Researcher
    2,254
    351
    63
    :rolleyes:
    it happens :P
     
Thread Status:
Not open for further replies.