Just 'guy', I was the only one involved in that change. It seems that in Sonic 2, there are some hardcoded areas like that. Unless you accounted for those and had found an exception.
MarkeyJester's Sonic 128 - REVAMPED Now available on GitHub
#17
KingofHarts 
Posted 01 September 2014 - 05:27 PM
- Call me back when people stop shitting in the punch bowl...
-
- Posts: 1480
- Joined: 07-August 10
- Gender:Male
- Wiki edits:1
06
So... that part should stay as is then?
#18
Clownacy
Posted 01 September 2014 - 06:35 PM
Yeah. The entire point of that commit was to make the system more S2-like. So, no bugfixes or the sort. Those would be made into a guide here that could applied to both S1-28 and S2.
What you're looking at shouldn't be a bug. You see, ObjHitWallLeft is most likely for non-player use only, and since the layer system doesn't apply to non-player objects, the additional checks aren't needed. What that code there is doing is checking the left/right collision bits(?) of the primary (default, no loop) collision.
What you're looking at shouldn't be a bug. You see, ObjHitWallLeft is most likely for non-player use only, and since the layer system doesn't apply to non-player objects, the additional checks aren't needed. What that code there is doing is checking the left/right collision bits(?) of the primary (default, no loop) collision.
This post has been edited by Clownacy: 01 September 2014 - 06:35 PM
#19
KingofHarts
Posted 01 September 2014 - 11:31 PM
- Call me back when people stop shitting in the punch bowl...
-
- Posts: 1480
- Joined: 07-August 10
- Gender:Male
- Wiki edits:1
06
Clownacy, on 01 September 2014 - 06:35 PM, said:
Yeah. The entire point of that commit was to make the system more S2-like. So, no bugfixes or the sort. Those would be made into a guide here that could applied to both S1-28 and S2.
What you're looking at shouldn't be a bug. You see, ObjHitWallLeft is most likely for non-player use only, and since the layer system doesn't apply to non-player objects, the additional checks aren't needed. What that code there is doing is checking the left/right collision bits(?) of the primary (default, no loop) collision.
What you're looking at shouldn't be a bug. You see, ObjHitWallLeft is most likely for non-player use only, and since the layer system doesn't apply to non-player objects, the additional checks aren't needed. What that code there is doing is checking the left/right collision bits(?) of the primary (default, no loop) collision.
Good to know. I will double check the commit difference to my source and make sure they match up then. Thanks for that!
#20
flamewing
Posted 02 September 2014 - 05:47 AM
- Emerald Hunter
-
- Posts: 831
- Joined: 11-October 10
- Gender:Male
- Location:Brasil
- Project:Sonic Classic Heroes; Sonic 2 Special Stage Editor; Sonic 3&K Heroes (on hold)
- Wiki edits:12
31
Clownacy, on 01 September 2014 - 06:35 PM, said:
What that code there is doing is checking the left/right collision bits(?) of the primary (default, no loop) collision.
Left/right/bottom collision bits of the primary collision, yes.
#22
flamewing
Posted 02 September 2014 - 07:05 AM
- Emerald Hunter
-
- Posts: 831
- Joined: 11-October 10
- Gender:Male
- Location:Brasil
- Project:Sonic Classic Heroes; Sonic 2 Special Stage Editor; Sonic 3&K Heroes (on hold)
- Wiki edits:12
31
The collision data itself is split like that (top solid in one bit, left/right/bottom solid in the other bit), so it can't do otherwise. But the way the check is done also matters -- finding walls check horizontally in collision data, finding ceilings check vertically up, etc.