[flamewing]

When building with -g MAP, a file called s2.map is generated (for S2 hacks). You open it in a text editor and search for the addresses mentioned in the error screen; the map file will give you the line in s2.asm corresponding to the address in question.

[Chilly Willy]

Why do people have so much trouble with odd address errors? The "fix" is simple - find every place you have byte data (actual bytes or strings or byte arrays), and then ALWAYS follow the last one with an "even" directive. PROBLEM SOLVED.

"But it's always an even number of bytes! I don't NEED to put an 'even' after it!!"

DO IT ANYWAY!!

[flamewing]

Chilly Willy, on 18 February 2012 - 08:23 PM, said:

Why do people have so much trouble with odd address errors? The "fix" is simple - find every place you have byte data (actual bytes or strings or byte arrays), and then ALWAYS follow the last one with an "even" directive. PROBLEM SOLVED.

This is more-or-less what I have been doing myself. But I still get the (increasingly less frequent) address error for other causes -- for example, the case I mentioned where an object calling DisplaySprite first and then calling DeleteObject afterwards due to its logic. Interestingly, I find that this is usually an S1 object.

[redhotsonic]

flamewing, on 18 February 2012 - 08:14 PM, said:

When building with -g MAP, a file called s2.map is generated (for S2 hacks). You open it in a text editor and search for the addresses mentioned in the error screen; the map file will give you the line in s2.asm corresponding to the address in question.

I put "build -g MAP", then triggered the error, but no s2.map (or s2built.map) was created.

Chilly Willy, on 18 February 2012 - 08:23 PM, said:

Why do people have so much trouble with odd address errors? The "fix" is simple - find every place you have byte data (actual bytes or strings or byte arrays), and then ALWAYS follow the last one with an "even" directive. PROBLEM SOLVED.

"But it's always an even number of bytes! I don't NEED to put an 'even' after it!!"

DO IT ANYWAY!!

I know you're meant to put it after all bytes like dc.b's and etc, but does that include all BINCLUDES and INCLUDES? Like:

; word_1E5A:
word_1E7A: BINCLUDE "art/palettes/EHZ ARZ Water.bin"; Emerald Hill/Aquatic Ruin Rotating Water palette
 even
word_1E9A: BINCLUDE "art/palettes/Hill Top Lava.bin"; Hill Top Lava palette
 even
word_1F1A: BINCLUDE "art/palettes/Wood Conveyor.bin"; Wood Conveyor Belts palette
 even
byte_1F2A: BINCLUDE "art/palettes/MTZ Cycle 1.bin"; Metropolis Cycle #1 palette
 even

Or

; word_1E5A:
word_1E7A: BINCLUDE "art/palettes/EHZ ARZ Water.bin"; Emerald Hill/Aquatic Ruin Rotating Water palette
word_1E9A: BINCLUDE "art/palettes/Hill Top Lava.bin"; Hill Top Lava palette
word_1F1A: BINCLUDE "art/palettes/Wood Conveyor.bin"; Wood Conveyor Belts palette
byte_1F2A: BINCLUDE "art/palettes/MTZ Cycle 1.bin"; Metropolis Cycle #1 palette
 even

[flamewing]

redhotsonic, on 19 February 2012 - 06:20 AM, said:

I put "build -g MAP", then triggered the error, but no s2.map (or s2built.map) was created.

Then you are putting it in the wrong place. Where you are supposed to put the "-g MAP" is in this line in build.bat:

"win32/asw" -xx -c -A s2.asm 

It should look like this:

"win32/asw" -xx -c -g MAP -A s2.asm 

(the line is different in the Hg disassembly, by the way)

redhotsonic, on 19 February 2012 - 06:20 AM, said:

I know you're meant to put it after all bytes like dc.b's and etc, but does that include all BINCLUDES and INCLUDES? Like:

Ideally, it must also be placed after all bincludes; also, after every include that has anything other than code (but if you are paranoid, even if it only has code).

This post has been edited by flamewing: 19 February 2012 - 07:25 AM

[Hitaxas]

Alright. I have added this to my hack, because I think it will be vital for me to have this in the future. But I have no address errors currently, what would be a simple way to test this? (IE: cause an address error on purpose)

[MarkeyJester]

		ILLEGAL

Is the most common to use, you can always do stuff such as:

		movea.w	#$0001,a0
		jmp	(a0)

To cause address errors.

[Hitaxas]

The screen doesn't display for me when using either of those methods. I renamed everything to work with the xenowhirl 2007 version and all that. I just get a black screen, nothing more.

[flamewing]

Try putting an 'even' right before the address error include.

Edit: nevermind, it can't be this.

This post has been edited by flamewing: 19 February 2012 - 08:15 AM

[Hitaxas]

Nevermind, I got it. I had to mess with the vdpComm and dma68kToVDP. It's all working quite nicely now.

[flamewing]

Time now to collect everything for the 2007 disassembly into the main post.

Edit: done.

This post has been edited by flamewing: 19 February 2012 - 08:31 AM

[SonicVaan]

Hitaxas, on 19 February 2012 - 08:14 AM, said:

Nevermind, I got it. I had to mess with the vdpComm and dma68kToVDP. It's all working quite nicely now.

Would you mind telling how you did that? I have the same problem here, only getting a black screen.

[flamewing]

SonicVaan, on 19 February 2012 - 01:47 PM, said:

Would you mind telling how you did that? I have the same problem here, only getting a black screen.

The first post now explains what has to be done.

[redhotsonic]

Stupid 2 questions, but does EVEN go above or below?

word_1E7A: BINCLUDE "art/palettes/EHZ ARZ Water.bin"; Emerald Hill/Aquatic Ruin Rotating Water palette
	even

OR

	even
word_1E7A: BINCLUDE "art/palettes/EHZ ARZ Water.bin"; Emerald Hill/Aquatic Ruin Rotating Water palette

Second question. There are a lot of align commands. Mainly "align 4" Then there's a few "align 100" and "align 200" and with Sonic and Tails, etc, "align $20000". Should these be replaced with even or should be left alone?

[Hitaxas]

Align goes above and even goes below. It does not hurt for them to be used with each other, never caused a problem for me.