[MainMemory]

So, I've just made some modifications to the disassembly that would give users the option to use macros for the title card mappings, allowing them to simply type the level's name as a string.
However, these macros cannot exactly duplicate the original mappings, and it makes editing other parts of the mappings a bit difficult, so I thought I would get your opinions before I commit it.
Here's a diff file for the latest revision b33615dd25a9 of the disassembly.
Just to be clear, the original mappings are still there, and are enabled by default, so chkbitperfect.bat still returns no differences.

Edit: should mention it requires SpritePiece.asm from the MapMacros branch in order to build.

This post has been edited by MainMemory: 04 May 2013 - 01:05 PM

[Caverns 4]

As long as the original mappings are allowed to be used I don't see a problem with it.

Though there is one part that bothers me.

Quote

However, these macros cannot exactly duplicate the original mappings, and it makes editing other parts of the mappings a bit difficult, so I thought I would get your opinions before I commit it.

Can we see a comparison image of the original and the Macro version? depending on how that impacts the appearance, I may well be against it.

[MainMemory]

[MoDule]

I'm not sure if it's in line with the project's philosophy to include something that can make the build non-bit-perfect, even if it's optional. I could be wrong, though.
The feature does sound useful, so why not turn it into a guide, instead?

[MainMemory]

At that point, I might as well just keep pointing people to Sonic 2 Text Code Generator.

[Caverns 4]

MainMemory, on 09 May 2013 - 01:14 PM, said:

At that point, I might as well just keep pointing people to Sonic 2 Text Code Generator.

I dunno, I actually think it looks alright; the alignment issue isn't that bad. Maybe it could be tweaked slightly to fix it? Either way, I think it's fine, I'd use it.

While the end result isn't "bit perfect" to Sonic 2, neither is a complete hack, and that's what this ASM is geared to, hacking.

[KingofHarts]

Caverns 4, on 13 May 2013 - 12:19 PM, said:

While the end result isn't "bit perfect" to Sonic 2, neither is a complete hack, and that's what this ASM is geared to, hacking.

That is well and good, but one of the main goals towards this ASM is also retaining a bit-perfect build.

[MainMemory]

There are already options in the disassembly that aren't bit-perfect: optimizing 0(aN) to (aN), extending the water table to encompass all zones, disabling the checksum check...

[MoDule]

Oh, I forgot about that. In that case, I'd say, go for it.

[KingofHarts]

Then there should be no issue with making your macro an optional addition, then. I suppose?
I'd personally prefer to use something like this over the original method...

This post has been edited by KingofHarts: 14 May 2013 - 12:59 AM

[Aerosol]

How hard would the mappings be to tweak afterwards, anyhow?