don't click here

Problem with Bobesh8's Sonic 1 SegaCD remake

Discussion in 'Engineering & Reverse Engineering' started by Trinitronity, Jan 23, 2016.

  1. Hello guys, TrinitroMan is here.
    Not sure if this is the right place to ask that question, so I really hope it is.
    Anyway, so I have downloaded this hack:
    http://shc.sonicrese...rg/history13/36
    And when I found out that almost all thee CDDA songs sound like amateur midis, I went ahead and replaced most of them with higher quality versions (I'm still not done with replacing, though).
    So what I found out is the following:
    Whenever I try to insert a song downloaded from the homepage of OCRemix, my emulator (Gens+) crashes as soon as it tries to load up that song.
    However, if I download the same song by converting a Youtube upload of it into an MP3 and insert it, then my emulator does not crash.
    But the thing is, not every OCRemix is uploaded on Youtube. This is especially true for every song from their Sound of Speed album (the one that is literally filled with Sonic remixes).

    And sadly, the emulator's manual does not tell me what I should do to fix the crashing problem.
    So how can I possibly fix the crashing problem?

    Also, how could I possibly fix the problem of the (unchanged) Invinsibility music not stopping to play when the Invinsibility ended while on Green Hill Zone with changed music?
    Because the Invinsibility music does stop to play when the Invinsibility ended while on Marble Zone with changed music, and both Green Hill's and Marble's new songs are ripped from Youtube using the same convertor.

    Would be glad if someone could help me out there instead of moving the thread to the trash immidiately with absolutely no warning. Thanks in advance!
     
  2. nineko

    nineko

    I am the Holy Cat Tech Member
    6,308
    486
    63
    italy
    Most mp3s from OCR use weird id3 tags, try stripping them with a tag editor (such as Winamp's). As a matter of fact, removing all the tags is the first thing I do when I download songs from OCR.
     
  3. Wait, Winamp has a tag editor?
    Where is it? Because I cannot find it for some reasons...
     
  4. Herm the Germ

    Herm the Germ

    Hmm, not bad. Well done, doctor! Member
    1,482
    0
    0
    Dresden, Saxony, Germany
    MIDI-to-SMPS-conversions, mostly. Takin' requests, too.
    Right click a file in your playlist, there should be an option something like "Edit Meta-Data". Alternatively, select a file in the playlist and hit Shift+E.
     
  5. Okay, I think I removed the tags now (using Herm the Germ's method), but sadly, the emulator still crashes, even after removing the tags.
    Furthermore, when viewing the file preview of the MP3, I can see that the OCRemix picture is still there, so did I miss some tags or what?
     
  6. nineko

    nineko

    I am the Holy Cat Tech Member
    6,308
    486
    63
    italy
    Yeah, apparently OCR's tags are so weird that Winamp can't even remove them entirely (I use another program to do that, but I suggested Winamp since it's popular and I assumed you already had it). It's still possible that this isn't related to your issue, but since different ReMixers use different encoders to make the MP3s, the only common factor are the tags, which are written by the OCR staff themselves. To further this theory, the ID3v2 tags are placed at the beginning of the file, the best place if you want to confuse a program which isn't expecting them.

    I should have replied with this detail sooner, but I wasn't at home earlier and from my previous post you can tell I hate to type on a phone.
     
  7. Wait, the ID3v2 tag is placed at the beginning of the file? Can I just remove it with a hex editor? If yes, then how can I know when the ID3v2 tag ends and should I just replace them with 00s?
     
  8. ValleyBell

    ValleyBell

    Tech Member
    246
    25
    28
    researching PC-98/X68000 sound drivers
    ID3v2 tags are indeed likely to crash programs that don't expect them - especially if they include pictures.

    The simplest way to remove ID3v2 tags via hex-editing is to search for the bytes "FF FB" and remove everything before, because most MP3 blocks begin with those two bytes.
    Alternatively you can try to get the length of the tag block by decoding the value stored at offset 06-09. (It's a Big Endian number where only the 7 lower bits in each byte are used - I.e. 0x8F0 is stored as 00 00 11 70)
    If you want to do that with multiple MP3s though, I'd probably just use a tool. I've been using Mp3tag most of the time. It's pretty powerful and I also used it to remove ID3v2 while keeping ID3v1.
     
  9. Thanks, that your idea with the FF FB bytes fixed the crashing problem.
    And now, onto figuring out why the stopping of the (unchanged) Invinsibility music is so inconsistent before I can even hope to make some actual coding tweaks of my own (probably a bad way to start learning Sonic ASM).
     
  10. Overlord

    Overlord

    Now playable in Smash Bros Ultimate Moderator
    19,237
    969
    93
    Long-term happiness
    I should probably note at this point it's considered bad form to hack other people's hacks. Especially without permission. Music changing on a CD game is fair enough because that's trivial, but anything more...
     
  11. Well, I would have course not release it without the original authors permission.
    If I get the permission, I could release an update version of that guy's hack.
    If not, then I can still hack it for my very own entertainment and simply not release it.
    In any case I would get the chance to learn some Sonic ASM hacking, and I could use my expieriences later on for my own hacks.
     
  12. Clownacy

    Clownacy

    Tech Member
    1,061
    607
    93
    Some folks get mad even if you don't distribute. It's just the matter of simply looking at their code.
     
  13. Well, I'm sorry, but I think that this is something to be accepted.
    I mean, retail games get hacked on a daily basis, so why not hacked and fanmade games either?
    That really reaks of elitism, something that I really do not like.
    And hey, sometimes someone has to see someone else's implementation of a code to truly understand the code.
    Yeah, I got that way of thinking thanks to the MUGEN community, where creations of other people get edited and distributed very often.

    I mean, I only want to do this in order to learn Sonic ASM coding, before I can make my own original hacks (which are a bit on the ambitious side for an amateur, but should be doable by an expert).
     
  14. Clownacy

    Clownacy

    Tech Member
    1,061
    607
    93
    It's not surprising people think this way after how many times we've been burned before: code stealers, hack disassemblers. In a community where people often contribute code in guides and actual disassemblies, it's pretty rude to overstep that and go straight for the code someone doesn't want you to see. It's no secret that I occasionally disassemble sections of others' ROMs, usually to find the source of crashes, but even I find it slimy to do so to learn ASM. That's what guides are for; if someone wanted to help you with that, they would have. Also, 'elitist'? Really? We're trying to treat each other's work with respect, and you're going against that just to benefit yourself, and we're the bad ones?
     
  15. winterhell

    winterhell

    Member
    1,165
    7
    18
    Modding retail games happens, yes.
    The key difference is they already make the millions out of the game, AND everybody knows the original product and who made it.

    A hack of a hack is a bad form because people might assume you made everything or that you didn't credit the original author well enough.
    I promise you, if you were in the reverse situation you wouldn't like someone taking your code, level layouts, sprites and whatnot and plastering them in their product.
    And if you say you would be ok with it, that's because you haven't done enough stuff. Its like 'Sure, if I win the lottery I'll buy all you guys shiny cars, donate to charity etc' but when the time actually comes...

    If you want to be doing this just for learning,
    a) don't release it publicly or otherwise
    b) couldn't you just do your changes on the original game?

    P.S. Modifying retail games is most of the times still considered illegal, and you can see it being enforced from time to time by banning players.Why don't you try to modify TF2, Dota 2 or CS:GO and watch what happens.
     
  16. Hmm...I guess you guys got a good points then.

    One last question, though: Where could I possibly find a Sonic 1/2/3 editor that edits the ROM directly instead of editing disassemblies or individual files inside a ROM?
    I mainly ask this because due to my MegaMan hacking, I'm pretty much used to editing the ROM directly.

    EDIT: Nevermind, I'm starting to figure out the whole disassemblies schtick.
     
  17. AURORA☆FIELDS

    AURORA☆FIELDS

    The cute one here Tech Member
    216
    24
    18
    Finland
    AMPS
    Hold on there now. I personally have been on this scene for 4 years, done all kinds of stuff, even pretty complex ASM edits, and I done not really care if someone goes out to rip code or other assets from my hack. In fact, I would encourage anyone with the knowledge to disassemble my hack and rip all the code out. But "why???!!!", you ask. The simple answer is; if someone is capable of disassembling my hack in the first place, they may as well be skilled enough to make any code in there by their own. Or even if now, they have done something rather complex and deserve a little cherry on top.

    Of course, when we talk about noobs going in to some random leaked disassembly to piss all over my work, then I wont be happy with it, because they don't need to put forth any effort to understand any of the code, they can just poke it with a stick and make it *kind of* work. But for someone who truly took it upon themselves to disassemble the ROM and understand the code, I have no problem with them 'stealing it'. So please do not assume everyone in this community act like the worst elitist scum we have been conditioned to accept.
     
  18. Zycor

    Zycor

    Unlike Sonic, I don't chuckle. Member
    195
    11
    18
    Beats me.
    The usual issue in those games is people cheating in matches. I don't think that's even comparable to modding. I know some people like to go into multiplayer games and cheat and that's their way of having fun, but that's cheating and that's trying to give yourself a competitive edge over others. If I make a new level in Sonic the Hedgehog, that's not really me giving myself an advantage over others. If I make a new gun or hat for TF2 that goes over another existing thing, that's also not giving myself an advantage necessarily. I've been on servers in TF2 where Scout's model had Pedobear's head for example. I would consider that modding and not cheating. Several servers I've been on have Quake's announcer on them. There are also servers that give you random character layouts or restrict you to the default loadouts for the cast. None of that will get you a Valve Anti Cheat ban. Making it so your gun hits all the time and always gets headshots and gives you as many kills against every player that you can gain without the game breaking is cheating.

    It's after midnight for me currently, so if that doesn't make sense, what I'm trying to say is you're trying to compare someone looking through someone else's code to cheating. There are a lot of places that offer code that is written for you to take advantage of and people get caught plagiarizing all the time. There's not really much you can do to stop people from stealing your code or trying to view it and tinker around with it. I've made some of the stupidest maps in DOOM with all sorts of textures from other games, and to be honest for a lot of modding scenes, that's what a lot of people do. That's how a lot of people get their start in game design.
     
  19. winterhell

    winterhell

    Member
    1,165
    7
    18
    I agree with you both.

    If someone made a derrivative of my work I'd like for them to at least try to contact me about it. As you say, if someone is willing to disassemble your stuff it means they are dedicated and it might be a form of flattery.

    On the other end of the spectrum there was recently a person that claimed they drew their spritesheet and immediately someone called him out with the source sprites.

    Maybe my example with Valve games were bad. I've seen people being banned for non-gameplay changes like reverting Battlefield 3's shaders to realistic and not washed-out-gray or for unlocking the framerate modifier on Dark Souls(both were not presented as giving the player an advantage, but just the companies being mad because bad).
    And some models on Quake 2 can be considered cheating as well since they reduce the player hitbox size and you cant hit him? I might be remembering it wrong. Anyway my point was that many companies don't like modding.
     
  20. Colton

    Colton

    Member
    9
    0
    0
    Semi off-topic, but some companies ENCOURAGED modding their games. Hell, id Software did just that with Q3TA. And both games' source is officially out on the internet so you can mod to your heart's content. AND they made their way to GitHub.